r82219 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r82218‎ | r82219 | r82220 >
Date:07:19, 16 February 2011
Author:catrope
Status:ok (Comments)
Tags:
Comment:
(bug 27302) Don't append the current timestamp for user/site modules when no user/site JS/CSS is present. Was caused by 1 being rounded down to 0, which is interpreted as 'now' by wfTimestamp(). This revision just drops timestamp rounding because it's not used consistently anyway
Modified paths:
  • /trunk/phase3/includes/OutputPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/OutputPage.php
——@@ -2496,7 +2496,7 @@
24972497 $timestamp = max( $timestamp, $module->getModifiedTime( $context ) );
24982498 }
24992499 // Add a version parameter so cache will break when things change
2500 - $query['version'] = wfTimestamp( TS_ISO_8601_BASIC, round( $timestamp, -2 ) );
 2500+ $query['version'] = wfTimestamp( TS_ISO_8601_BASIC, $timestamp );
25012501 }
25022502 // Make queries uniform in order
25032503 ksort( $query );

Follow-up revisions

RevisionCommit summaryAuthorDate
r822201.17wmf1: MFT r80495, r80765, r81177, r82000, r82155, r82156, r82191, r82200,...catrope07:23, 16 February 2011
r822481.17wmf1: MFT r82219, r82247catrope14:30, 16 February 2011
r82468(bug 27302) Avoid unnecessary requests for user and site modules if the relev...catrope17:07, 19 February 2011
r85151MFT: r82000, r82004, r82020, r82025, r82038, r82039, r82048, r82070, r82081, ...demon20:39, 1 April 2011

Comments

#Comment by Catrope (talk | contribs)   15:05, 16 February 2011

This cut CPU load for the bits Apaches in half: http://file.status.net/i/identica/catrope-20110216T150241-xmvxh2t.png

Status & tagging log