r93282 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r93281‎ | r93282 | r93283 >
Date:16:36, 27 July 2011
Author:jeroendedauw
Status:deferred
Tags:lamecommitsummary 
Comment:
Modified paths:
  • /trunk/extensions/SemanticMediaWiki/includes/storage/SMW_SQLStore2.php (modified) (history)
  • /trunk/extensions/SemanticMediaWiki/includes/storage/SMW_Store.php (modified) (history)
  • /trunk/extensions/SemanticMediaWiki/specials/SearchTriple/SMW_SpecialBrowse.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticMediaWiki/specials/SearchTriple/SMW_SpecialBrowse.php
@@ -362,7 +362,7 @@
363363
364364 if ( $incoming && $smwgBrowseShowInverse ) {
365365 $oppositeprop = SMWPropertyValue::makeUserProperty( wfMsg( 'smw_inverse_label_property' ) );
366 - $labelarray = &smwfGetStore()->getPropertyValues( $property->getDataItem(), $oppositeprop->getDataItem() );
 366+ $labelarray = &smwfGetStore()->getPropertyValues( $property->getDataItem()->getDiWikiPage(), $oppositeprop->getDataItem() );
367367 $rv = ( count( $labelarray ) > 0 ) ? $labelarray[0]->getLongWikiText():
368368 wfMsg( 'smw_inverse_label_default', $property->getWikiValue() );
369369 } else {
Index: trunk/extensions/SemanticMediaWiki/includes/storage/SMW_Store.php
@@ -163,7 +163,7 @@
164164 * If called with $subject == null, all values for the given property
165165 * are returned.
166166 *
167 - * @param $subject mixed SMWDataItem or null
 167+ * @param $subject mixed SMWDIWikiPage or null
168168 * @param $property SMWDIProperty
169169 * @param $requestoptions SMWRequestOptions
170170 *
Index: trunk/extensions/SemanticMediaWiki/includes/storage/SMW_SQLStore2.php
@@ -182,7 +182,7 @@
183183 /**
184184 * @see SMWStore::getPropertyValues
185185 *
186 - * @param $subject mixed SMWDataItem or null
 186+ * @param $subject mixed SMWDIWikiPage or null
187187 * @param $property SMWDIProperty
188188 * @param $requestoptions SMWRequestOptions
189189 *

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r93276attempt to fix issue, not testedjeroendedauw15:24, 27 July 2011
r93280fu r93276jeroendedauw16:02, 27 July 2011

Status & tagging log